Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1497 Delete groups that were deselected from provisioning #4683

Merged
merged 10 commits into from
Jan 9, 2024
Merged

N21-1497 Delete groups that were deselected from provisioning #4683

merged 10 commits into from
Jan 9, 2024

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Jan 8, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1497
hpi-schul-cloud/dof_app_deploy#754
hpi-schul-cloud/nuxt-client#2987
hpi-schul-cloud/e2e-system-tests#169

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

This was referenced Jan 8, 2024
Merged
Merged
Merged
arnegns
arnegns approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@arnegns arnegns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things only

apps/server/src/modules/legacy-school/service/provisioning-options-update-service.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 5344554 into main Jan 9, 2024
45 of 46 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1497-delete-groups branch January 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @arnegns